linux-kernel - Re: [PATCH] staging/comedi: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOTypNQboxf2Oy0x2vNu8MHaqddQ5CdVTAeU9yOJCucu7F7X7g@mail.gmail.com>
Date:	Sun, 14 Oct 2012 22:51:53 +0900
From:	Toshiaki Yamane <yamanetoshi@...il.com>
To:	Greg Kroah-Hartman <greg@...ah.com>
Cc:	Ian Abbott <abbotti@....co.uk>,
	Frank Mori Hess <fmhess@...rs.sourceforge.net>,
	linux-kernel@...r.kernel.org,
	YAMANE Toshiaki <yamanetoshi@...il.com>
Subject: Re: [PATCH] staging/comedi: Use dev_ printks in drivers/usbdux.c

On Sun, Oct 14, 2012 at 10:38 PM, YAMANE Toshiaki <yamanetoshi@...il.com> wrote:
> fixed below checkpatch warning.
> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
>
> Signed-off-by: YAMANE Toshiaki <yamanetoshi@...il.com>
> ---
>  drivers/staging/comedi/drivers/usbdux.c |   10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
> index b536bba..46c5bfb 100644
> --- a/drivers/staging/comedi/drivers/usbdux.c
> +++ b/drivers/staging/comedi/drivers/usbdux.c
> @@ -2386,14 +2386,12 @@ static int usbdux_attach_usb(struct comedi_device *dev,
>         down(&start_stop_sem);
>         this_usbduxsub = usb_get_intfdata(uinterf);
>         if (!this_usbduxsub || !this_usbduxsub->probed) {
> -               printk(KERN_ERR
> -                      "comedi%d: usbdux: error: attach_usb failed, not connected\n",
> -                      dev->minor);
> +               dev_err(&uinterf->dev,
> +                       "usbdux: error: attach_usb failed, not connected\n");
>                 ret = -ENODEV;
>         } else if (this_usbduxsub->attached) {
> -               printk(KERN_ERR
> -                      "comedi%d: usbdux: error: attach_usb failed, already attached\n",
> -                      dev->minor);
> +               dev_err(&uinterf->dev,
> +                       "error: attach_usb failed, already attached\n");
>                 ret = -ENODEV;
>         } else
>                 ret = usbdux_attach_common(dev, this_usbduxsub);
> --
> 1.7.9.5
>

I cannot judge which is better or not ...

-- 

Regards,

YAMANE Toshiaki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/