linux-kernel - Re: [PATCH RFC] brd: Add miscdevice to control creation and deletion of ramdisks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121014033835.GA30463@order.stressinduktion.org>
Date:	Sun, 14 Oct 2012 05:38:35 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	npiggin@...nel.dk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] brd: Add miscdevice to control creation and deletion of ramdisks

On Sun, Oct 14, 2012 at 04:48:36AM +0200, Hannes Frederic Sowa wrote:
> +	case BRD_CTL_DEL:
> +		error = get_user(val, (int __user *)param);
> +		if (error < 0)
> +			break;
> +		if ((val & max_part) != 0) {
> +			error = -EINVAL;
> +			break;
> +		}
> +		val >>= part_shift;
> +		brd2 = NULL;
> +		list_for_each_entry(brd, &brd_devices, brd_list) {
> +			if (brd->brd_number == val) {
> +				brd2 = brd;
> +				break;
> +			}
> +		}
> +		if (brd2 == NULL) {
> +			error = -ENODEV;
> +			break;
> +		}
> +		brd_del_one(brd2);
> +		break;

Sorry, first bug spotted. I should check the bd_openers before destroying the
device. Will be fixed in a follow-up patch, if needed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/