linux-kernel - Re: CONFIG_MODULE_SIG breaks out-of-tree modules in modpost.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17290.1350303547@warthog.procyon.org.uk>
Date:	Mon, 15 Oct 2012 13:19:07 +0100
From:	David Howells <dhowells@...hat.com>
To:	Valdis Kletnieks <Valdis.Kletnieks@...edu>
Cc:	dhowells@...hat.com, Rusty Russell <rusty@...tcorp.com.au>,
	linux-kernel@...r.kernel.org
Subject: Re: CONFIG_MODULE_SIG breaks out-of-tree modules in modpost.

Valdis Kletnieks <Valdis.Kletnieks@...edu> wrote:

> /bin/sh: -c: line 0: syntax error near unexpected token `;'
> /bin/sh: -c: line 0: `set -e;  ; echo 'cmd_/usr/src/valdis/NVIDIA-Linux-x86_64-304.51/kernel/nvidia.ko := ' > /usr/src/valdis/NVIDIA-Linux-x86_64-304.51/kernel/.nvidia.ko.cmd'

I would guess that this is from Kbuild.include's 'if_changed' macro:

	if_changed = $(if $(strip $(any-prereq) $(arg-check)),       \
		@set -e;                                             \
		$(echo-cmd) $(cmd_$(1));                             \
		echo 'cmd_$@ := $(make-cmd)' > $(dot-target).cmd)

unless nvidia.ko has its own build rules.

It looks like either $(call if_changed) got invoked with no arguments or
$(cmd_$(1)) didn't exist.

Could you find out what $(1) was by adding a bit:

	if_changed = $(if $(strip $(any-prereq) $(arg-check)),       \
		$(info XXXX $(1))				     \
		@set -e;                                             \
		$(echo-cmd) $(cmd_$(1));                             \
		echo 'cmd_$@ := $(make-cmd)' > $(dot-target).cmd)

You should see a line looking something like:

	XXX link_o_target

emitted by make just before it the error occurs.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/