linux-kernel - Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd9Lqw5fwuaY7gEJiFK2qYSRW-WNVP1cEjc1sbJqBLLt+g@mail.gmail.com>
Date:	Mon, 15 Oct 2012 22:20:14 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	akpm@...ux-foundation.org, bfields@...ldses.org,
	viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Ravishankar N <ravi.n1@...sung.com>,
	Amit Sahrawat <a.sahrawat@...sung.com>
Subject: Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if
 fat_dget() fails

2012/10/15 OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>:
> Namjae Jeon <linkinjeon@...il.com> writes:
>
>>> OK, I think I got where is wrong. If it is the subdir of rootdir,
>>> fat_dget() should get the inode of root?
>> That is correct. Whenever fat_dget() is called for sub-directories
>> which is in root folder, we assign root inode as parent inode.
>>>
>>> So, I guess if parent_logstart == 0, it is BUG().
>> Would you explain more why you think it is BUG() ?
>
> Because root dentry is never expired until umount. So, fat_dget()
> shouldn't never fail to get inode for subdir of rootdir. Otherwise,
> "stale_rw" will not be working in the case even if there is cache.
>
> I.e. I think we don't need to check parent_logstart == 0.
Yes, You're right.  I found this condition is really not needed when I
check again.
I will remove this code.
Thanks OGAWA!
>
> Thanks.
> --
> OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/