linux-kernel - Re: [PATCH v6 04/10] ipc: add new SHM_SET command for sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1350327628.2819.21.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Mon, 15 Oct 2012 20:00:28 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Stanislav Kinsbursky <skinsbursky@...allels.com>
CC:	<akpm@...ux-foundation.org>, <catalin.marinas@....com>,
	<will.deacon@....com>, <dhowells@...hat.com>,
	<manfred@...orfullife.com>, <hughd@...gle.com>,
	<jmorris@...ei.org>, <mtk.manpages@...il.com>,
	<kosaki.motohiro@...fujitsu.com>, <paulmck@...ux.vnet.ibm.com>,
	<sds@...ho.nsa.gov>, <devel@...nvz.org>, <a.p.zijlstra@...llo.nl>,
	<cmetcalf@...era.com>, <linux-driver@...gic.com>,
	<ron.mercer@...gic.com>, <viro@...iv.linux.org.uk>,
	<eparis@...isplace.org>, <tglx@...utronix.de>,
	<jitendra.kalsaria@...gic.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-security-module@...r.kernel.org>, <ebiederm@...ssion.com>,
	<casey@...aufler-ca.com>
Subject: Re: [PATCH v6 04/10] ipc: add new SHM_SET command for sys_shmctl()
 call

On Mon, 2012-10-15 at 19:59 +0400, Stanislav Kinsbursky wrote:
> New SHM_SET command will be interpreted exactly as IPC_SET, but also will
> update key, cuid and cgid values. IOW, it allows to change existent key value.
> The fact, that key is not used is checked before update. Otherwise -EEXIST is
> returned.
[...]
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
[...]
> @@ -759,6 +763,10 @@ static int shmctl_down(struct ipc_namespace *ns, int shmid, int cmd,
>  	case IPC_RMID:
>  		do_shm_rmid(ns, ipcp);
>  		goto out_up;
> +	case SHM_SET:
> +		err = ipc_update_key(&shm_ids(ns), &shmid64.shm_perm, ipcp);
> +		if (err)
> +			break;
[...]

Please add /* fall through */ here, and in the similar cases in patches
5 and 7, to make clear that it's deliberate.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/