linux-kernel - Re: [PATCH v3 6/8] perf tools: Try to find cross-built objdump path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Oct 2012 01:59:06 +0300
From:	Irina Tirdea <irina.tirdea@...il.com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	Paul Mackerras <paulus@...ba.org>,
	David Ahern <dsahern@...il.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Pekka Enberg <penberg@...nel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung.kim@....com>,
	Irina Tirdea <irina.tirdea@...el.com>
Subject: Re: [PATCH v3 6/8] perf tools: Try to find cross-built objdump path

>>
>> +     if (!objdump_path)
>> +             try_objdump_path(session);
>
> Please do the test on perf_session_env__lookup_objdump() and handle
> errors, i.e. what happens if that strdup/asprintf fails?
>
> Ok, that is unlikely, but not impossible, but what happens if we don't
> find the right objdump? Shouldn't we use ui__error("please install
> required objdump" (or a better, more detailed message)?
>

My initial intention was to use the default "objdump" in case of any
error. On second though, this should not be allowed since the data was
recorded on a different architecture. I'll print error messages
instead.

Thanks,
Irina
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/