linux-kernel - Re: [PATCH 1/2] regulator: core: Check before enabling regulator while setting constraints.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121016053458.GD8670@opensource.wolfsonmicro.com>
Date:	Tue, 16 Oct 2012 14:35:00 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Yadwinder Singh Brar <yadi.brar@...sung.com>
Cc:	linux-kernel@...r.kernel.org, sameo@...ux.intel.com,
	Liam Girdwood <lrg@...com>
Subject: Re: [PATCH 1/2] regulator: core: Check before enabling regulator
 while setting constraints.

On Tue, Oct 16, 2012 at 10:54:19AM +0530, Yadwinder Singh Brar wrote:
> This patch adds check, whether regulator is already enabled before enabling it
> while setting machine constraints. Since some PMICs have same register bits
> for setting opmode and enabling/disabling the regulator, so it will overwrite
> the settings (if any)done by set_mode/set_suspend_mode callbacks when it
> enables regulator without checking previous status.

This sounds like a bug in the driver, these ops are supposed to be
repeatable at will.  The driver needs to remember the mode setting when
doing enable or disable, and setting the mode should not change the
enable status.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/