[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAHp75VdVLh7JN10YEiA1P=iV-T3enpL639_ZKSsj1ubzvNihNg@mail.gmail.com>
Date: Tue, 16 Oct 2012 13:14:52 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Vinod Koul <vinod.koul@...el.com>,
linux-kernel@...r.kernel.org, spear-devel <spear-devel@...t.st.com>
Subject: Re: [PATCH] dmatest: terminate all ongoing transfers before
submitting new one
On Tue, Oct 16, 2012 at 12:52 PM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
>>> Also, the proposed solution might hide some other important errors. We may need
>>> to terminate transfers when we found that an error is there in last transfers:
>> I think it could be better than first solution, but what do you think
>> about marking each transfer with corresponding id?
>
> But dma_test expects the transfer to finish within timeout. If it
> doesn't, then that's
> an error.
>
> So, for testing your s/w emulation, you must pass higher timeout. And
> terminating
> transfers for error case would be better, to make them timeout safe.
Yeah, seems the patch is not necessary.
In case of software emulation we just have a test passed much slow...
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists