linux-kernel - Re: [PATCH 1/2] SLUB: remove hard coded magic numbers from resiliency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0000013a69d41636-b42ca340-7e04-431d-86ca-f38610bfaaf8-000000@email.amazonses.com>
Date:	Tue, 16 Oct 2012 13:47:18 +0000
From:	Christoph Lameter <cl@...ux.com>
To:	David Rientjes <rientjes@...gle.com>
cc:	Richard Kennedy <richard@....demon.co.uk>,
	Pekka Enberg <penberg@...nel.org>,
	Matt Mackall <mpm@...enic.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] SLUB: remove hard coded magic numbers from
 resiliency_test

On Mon, 15 Oct 2012, David Rientjes wrote:

> On Mon, 15 Oct 2012, Christoph Lameter wrote:
>
> > > Use the always inlined function kmalloc_index to translate
> > > sizes to indexes, so that we don't have to have the slab indexes
> > > hard coded in two places.
> >
> > Acked-by: Christoph Lameter <cl@...ux.com>
> >
>
> Shouldn't this be using get_slab() instead?

Right that would even be better.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/