linux-kernel - Re: [PATCH] x86, AMD, NB: Cleanup and improve NB descriptors handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Oct 2012 22:12:55 +0800
From:	Daniel J Blueman <daniel@...ascale-asia.com>
To:	Borislav Petkov <bp@...64.org>
CC:	Steffen Persvold <sp@...ascale.com>, X86-ML <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <borislav.petkov@....com>
Subject: Re: [PATCH] x86, AMD, NB: Cleanup and improve NB descriptors handling

On 16/10/2012 22:06, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@....com>
>
> First of all, the double loop of first counting the northbridges on
> the system, then allocating them and then going over them again was
> bugging me for a long time now. Fix it by moving the allocation of the
> descriptors in the initial iteration path.
>
> Then, modify the enclosing _info structure to contain two NB descriptor
> structures: and array of 8 NB descs which contains the first 8 possible
> NB descriptors for all single-board AMD systems out there. This is no
> different from the current state of affairs and is done this way so that
> lookup of those descriptors remains fast.
>
> Then, there's a linked list of further NB descs which are for large,
> confederated systems like NumaScale where more than 8 nodes are present
> in the fabric and are visible to the single system Linux image. We keep
> those unique by introducing the PCI domain ID into the node ID used for
> descriptor lookup.
>
> Rest of the code is cleanup and readability improvements.
[...]

Looks good.

I recall there were some other areas that needed fixing, so I'll rebase
on top of this tomorrow and present my change so far.

Thanks,
Daniel

-- 
Daniel J Blueman
Principal Software Engineer, Numascale Asia

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/