linux-kernel - Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121016150417.GA4379@localhost>
Date:	Tue, 16 Oct 2012 23:04:17 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Yuanhan Liu <yuanhan.liu@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, Jeff Garzik <jgarzik@...ox.com>,
	Viresh Kumar <viresh.linux@...il.com>,
	linux-ide@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/5] ata: suspend/resume callbacks should be
 conditionally compiled on CONFIG_PM_SLEEP

// Add CC to PM list

On Tue, Oct 16, 2012 at 10:59:01PM +0800, Yuanhan Liu wrote:
> This will fix warnings like following when CONFIG_PM_SLEEP is not set:
> 
>         warning: 'xxx_suspend' defined but not used [-Wunused-function]
>         warning: 'xxx_resume' defined but not used [-Wunused-function]
> 
> Because
> 	SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)
> 
> Only references the callbacks on CONFIG_PM_SLEEP (instead of CONFIG_PM).
> 
> Cc: Jeff Garzik <jgarzik@...ox.com>
> Cc: Viresh Kumar <viresh.linux@...il.com>
> Cc: linux-ide@...r.kernel.org
> Signed-off-by: Yuanhan Liu <yuanhan.liu@...ux.intel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
>  drivers/ata/ahci_platform.c  |    2 +-
>  drivers/ata/pata_arasan_cf.c |    2 +-
>  drivers/ata/sata_highbank.c  |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
> index b1ae480..b7078af 100644
> --- a/drivers/ata/ahci_platform.c
> +++ b/drivers/ata/ahci_platform.c
> @@ -238,7 +238,7 @@ static int __devexit ahci_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
>  static int ahci_suspend(struct device *dev)
>  {
>  	struct ahci_platform_data *pdata = dev_get_platdata(dev);
> diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> index 26201eb..3fe2f66 100644
> --- a/drivers/ata/pata_arasan_cf.c
> +++ b/drivers/ata/pata_arasan_cf.c
> @@ -908,7 +908,7 @@ static int __devexit arasan_cf_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
>  static int arasan_cf_suspend(struct device *dev)
>  {
>  	struct ata_host *host = dev_get_drvdata(dev);
> diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
> index 0d7c4c2..b045b19 100644
> --- a/drivers/ata/sata_highbank.c
> +++ b/drivers/ata/sata_highbank.c
> @@ -378,7 +378,7 @@ static int __devexit ahci_highbank_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
>  static int ahci_highbank_suspend(struct device *dev)
>  {
>  	struct ata_host *host = dev_get_drvdata(dev);
> -- 
> 1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/