linux-kernel - Re: [PATCH v4 3/6] perf tools: add --addr2line command line option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121016152153.GD6807@ghostprotocols.net>
Date:	Tue, 16 Oct 2012 08:21:53 -0700
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Irina Tirdea <irina.tirdea@...il.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	Paul Mackerras <paulus@...ba.org>,
	David Ahern <dsahern@...il.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Pekka Enberg <penberg@...nel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Irina Tirdea <irina.tirdea@...el.com>
Subject: Re: [PATCH v4 3/6] perf tools: add --addr2line command line option

Em Tue, Oct 16, 2012 at 02:33:37AM +0300, Irina Tirdea escreveu:
> From: Irina Tirdea <irina.tirdea@...el.com>
> 
> When analyzing data recorded on a target with a different architecture
> than the host, we must use addr2line from the toolchain for that
> architecture.
> 
> Add a command line option to allow setting addr2line at runtime.

You're doing two things here:

1. Adding --addr2line

2. fixing a bug for unresolved symbols

Please try not to do that, instead provide two patches, one addressing
each issue.

Furthermore, Namhyung fixed #2 already:

commit a2c1311c4cbd47a087e95be18fee79ead3d0744b
Author: Namhyung Kim <namhyung.kim@....com>
Date:   Mon Oct 15 12:39:42 2012 +0900

    perf tools: Fix segfault when using srcline sort key

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/