linux-kernel - Re: [PATCH 08/17] backlight: jornada720: fix checkpatch error and warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <507D8162.2080208@gmail.com>
Date:	Tue, 16 Oct 2012 17:46:42 +0200
From:	Kristoffer Eriksson <kristoffer.ericson@...il.com>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	'Andrew Morton' <akpm@...ux-foundation.org>,
	'LKML' <linux-kernel@...r.kernel.org>,
	'Richard Purdie' <rpurdie@...ys.net>
Subject: Re: [PATCH 08/17] backlight: jornada720: fix checkpatch error and
 warning

Thanks,

Acked-by: Kristoffer Ericson <kristoffer.ericson@...il.com>

Best wishes
Kristoffer Ericson

Jingoo Han skrev 2012-10-16 09:30:
> This patch fixes the checkpatch error and warning as below:
>
> WARNING: line over 80 characters
> ERROR: return is not a function, parentheses are not required
>
> Also, long comments are fixed for the preferred style.
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> Cc: Richard Purdie <rpurdie@...ys.net>
> ---
>   drivers/video/backlight/jornada720_bl.c  |   34 ++++++++++++++++++-----------
>   drivers/video/backlight/jornada720_lcd.c |    3 +-
>   2 files changed, 23 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
> index 16f593b..c23801c 100644
> --- a/drivers/video/backlight/jornada720_bl.c
> +++ b/drivers/video/backlight/jornada720_bl.c
> @@ -48,7 +48,7 @@ static int jornada_bl_get_brightness(struct backlight_device *bd)
>   
>   	jornada_ssp_end();
>   
> -	return (BL_MAX_BRIGHT - ret);
> +	return BL_MAX_BRIGHT - ret;
>   }
>   
>   static int jornada_bl_update_status(struct backlight_device *bd)
> @@ -58,7 +58,8 @@ static int jornada_bl_update_status(struct backlight_device *bd)
>   	jornada_ssp_start();
>   
>   	/* If backlight is off then really turn it off */
> -	if ((bd->props.power != FB_BLANK_UNBLANK) || (bd->props.fb_blank != FB_BLANK_UNBLANK)) {
> +	if ((bd->props.power != FB_BLANK_UNBLANK) ||
> +		(bd->props.fb_blank != FB_BLANK_UNBLANK)) {
>   		ret = jornada_ssp_byte(BRIGHTNESSOFF);
>   		if (ret != TXDUMMY) {
>   			pr_info("brightness off timeout\n");
> @@ -77,18 +78,23 @@ static int jornada_bl_update_status(struct backlight_device *bd)
>   			goto out;
>   		}
>   
> -		/* at this point we expect that the mcu has accepted
> -		   our command and is waiting for our new value
> -		   please note that maximum brightness is 255,
> -		   but due to physical layout it is equal to 0, so we simply
> -		   invert the value (MAX VALUE - NEW VALUE). */
> -		if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness) != TXDUMMY) {
> +		/*
> +		 * at this point we expect that the mcu has accepted
> +		 * our command and is waiting for our new value
> +		 * please note that maximum brightness is 255,
> +		 * but due to physical layout it is equal to 0, so we simply
> +		 * invert the value (MAX VALUE - NEW VALUE).
> +		 */
> +		if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness)
> +			!= TXDUMMY) {
>   			pr_err("set brightness failed\n");
>   			ret = -ETIMEDOUT;
>   		}
>   
> -		/* If infact we get an TXDUMMY as output we are happy and dont
> -		   make any further comments about it */
> +		/*
> +		 * If infact we get an TXDUMMY as output we are happy and dont
> +		 * make any further comments about it
> +		 */
>   out:
>   	jornada_ssp_end();
>   
> @@ -121,9 +127,11 @@ static int jornada_bl_probe(struct platform_device *pdev)
>   
>   	bd->props.power = FB_BLANK_UNBLANK;
>   	bd->props.brightness = BL_DEF_BRIGHT;
> -	/* note. make sure max brightness is set otherwise
> -	   you will get seemingly non-related errors when
> -	   trying to change brightness */
> +	/*
> +	 * note. make sure max brightness is set otherwise
> +	 * you will get seemingly non-related errors when
> +	 * trying to change brightness
> +	 */
>   	jornada_bl_update_status(bd);
>   
>   	platform_set_drvdata(pdev, bd);
> diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
> index 635b305..4b412cb 100644
> --- a/drivers/video/backlight/jornada720_lcd.c
> +++ b/drivers/video/backlight/jornada720_lcd.c
> @@ -101,7 +101,8 @@ static int jornada_lcd_probe(struct platform_device *pdev)
>   	struct lcd_device *lcd_device;
>   	int ret;
>   
> -	lcd_device = lcd_device_register(S1D_DEVICENAME, &pdev->dev, NULL, &jornada_lcd_props);
> +	lcd_device = lcd_device_register(S1D_DEVICENAME, &pdev->dev, NULL,
> +					&jornada_lcd_props);
>   
>   	if (IS_ERR(lcd_device)) {
>   		ret = PTR_ERR(lcd_device);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/