linux-kernel - Re: [PATCH] rcu: restore correct batch limiting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1350482482.26103.495.camel@edumazet-glaptop>
Date:	Wed, 17 Oct 2012 16:01:22 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Hillf Danton <dhillf@...il.com>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu: restore correct batch limiting

On Wed, 2012-10-17 at 21:18 +0800, Hillf Danton wrote:

> >                                         /* did other CPU force QS recently? */
> > -       long            blimit;         /* Upper limit on a processed batch */
> > +       int             blimit;         /* Upper limit on a processed batch */
> >
> >         /* 3) dynticks interface. */
> > +       int             dynticks_snap;  /* Per-GP tracking for dynticks. */
> >         struct rcu_dynticks *dynticks;  /* Shared per-CPU dynticks state. */
> > -       int dynticks_snap;              /* Per-GP tracking for dynticks. */
> 
> Hm, no words in change log for shuffling dynticks_snap...

I dont like adding two 32bit holes on a structure ;)

This kind of trivial things dont need a changelog, especially when
fixing a critical bug.

I let Paul add this if he really wants.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/