| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Oct 2012 22:32:37 +0530 From: Viresh Kumar <viresh.kumar@...aro.org> To: Joe Perches <joe@...ches.com> Cc: "hongbo.zhang" <hongbo.zhang@...aro.org>, linaro-dev@...ts.linaro.org, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, STEricsson_nomadik_linux@...t.st.com, kernel@...oocommunity.org, linaro-kernel@...ts.linaro.org, "hongbo.zhang" <hongbo.zhang@...aro.com>, patches@...aro.org Subject: Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver. On 17 October 2012 22:28, Joe Perches <joe@...ches.com> wrote: >> > +#include <linux/slab.h> >> > +#include <linux/module.h> >> > +#include <linux/platform_device.h> >> > +#include <linux/cpufreq.h> >> > +#include <linux/cpu_cooling.h> >> > +#include <linux/err.h> >> >> should be in alphabetical order > > There's no agreed kernel convention here. > Some prefer christmas tree (shortest to longest length) :) I have seen a number of times this happening, because the list isn't in alphabetical order people aren't able to easily read if an #include ... is already there or not. And so one header file is included multiple times. Because git diff only shows few lines above and below a change, even people can't catch it in reviews. That's why they must always be in alphabetical order. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists