linux-kernel - RE: [PATCH v3] Prevent devices with RMRRs from being placed into SI Domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9774516974AF5F4C8A2C3C69CD341233233D0E28@G2W2530.americas.hpqcorp.net>
Date:	Wed, 17 Oct 2012 21:19:20 +0000
From:	"Mingarelli, Thomas" <Thomas.Mingarelli@...com>
To:	"Mingarelli, Thomas" <Thomas.Mingarelli@...com>,
	Alex Williamson <alex.williamson@...hat.com>,
	David Woodhouse <dwmw2@...radead.org>,
	"Don Dutile" <ddutile@...hat.com>
CC:	"Khan, Shuah" <shuah.khan@...com>,
	"Knippers, Linda" <linda.knippers@...com>,
	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] Prevent devices with RMRRs from being placed into SI
 Domain

I meant to edit the preamble with no reference to init. This patch will prevent any device with an RMRR association from getting placed into the SI Domain and any time.


Tom

-----Original Message-----
From: Mingarelli, Thomas 
Sent: Wednesday, October 17, 2012 4:17 PM
To: Alex Williamson; David Woodhouse; Don Dutile
Cc: Khan, Shuah; Mingarelli, Thomas; Knippers, Linda; iommu@...ts.linux-foundation.org; linux-kernel@...r.kernel.org
Subject: [PATCH v3] Prevent devices with RMRRs from being placed into SI Domain

This patch is to prevent devices that have RMRRs associated with them to
not be placed into the SI Domain during init. We don't put USB devices
into this category, however. This fixes the issue where the RMRR info
for devices being placed in and out of the SI Domain gets lost.

Signed-off-by: Thomas Mingarelli <thomas.mingarelli@...com>
Tested-by: Shuah Khan <shuah.khan@...com>
----
PATCH v1: https://lkml.org/lkml/2012/6/15/204
PATCH v2: https://lkml.org/lkml/2012/9/18/354


drivers/iommu/intel-iommu.c |   30 ++++++++++++++++++++++++++++++
 1 files changed, 30 insertions(+), 0 deletions(-)

diff -up ./drivers/iommu/intel-iommu.c.ORIG ./drivers/iommu/intel-iommu.c
--- ./drivers/iommu/intel-iommu.c.ORIG	2012-10-16 09:34:23.148089944 -0500
+++ ./drivers/iommu/intel-iommu.c	2012-10-17 20:41:40.509642356 -0500
@@ -2320,8 +2320,38 @@ static int domain_add_dev_info(struct dm
 	return 0;
 }
 
+static bool device_has_rmrr(struct pci_dev *dev)
+{
+	struct dmar_rmrr_unit *rmrr;
+	int i;
+
+	for_each_rmrr_units(rmrr) {
+		for (i = 0; i < rmrr->devices_cnt; i++) {
+			/*
+			 * Here we are just concerned with checking each device
+			 * that has an RMRR associated with it and not allow it
+			 * to be placed into the SI Domain during startup.
+			*/
+			if (rmrr->devices[i] == dev)
+				return true;
+		}
+	}
+	return false;
+}
+
 static int iommu_should_identity_map(struct pci_dev *pdev, int startup)
 {
+
+	/*
+	 * This is where we will refuse any device that has an
+	 * RMRR associated with it and is not a USB device and
+	 * NOT allow it to be placed into the SI Domain. We don't
+	 * need a separate bit for this because it could be ANY device.
+	 */
+	if (device_has_rmrr(pdev) &&
+		(pdev->class >> 8) != PCI_CLASS_SERIAL_USB)
+			return 0;
+
 	if ((iommu_identity_mapping & IDENTMAP_AZALIA) && IS_AZALIA(pdev))
 		return 1;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/