linux-kernel - [PATCH] Input: serio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Oct 2012 08:35:17 +0000
From:	Mischa Jonker <Mischa.Jonker@...opsys.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Mischa Jonker <mischa.jonker@...opsys.com>
CC:	"m.d.s.x.jonker@...il.com" <m.d.s.x.jonker@...il.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arc-linux-dev@...opsys.com" <arc-linux-dev@...opsys.com>
Subject: [PATCH] Input: serio - Add ARC PS/2 driver

Hi Dmitry,

Thanks again for your quick reply. 

>> +	void *data, *status;
>These 2 should be annotated as __iomem. May I also suggest calling them data_addt and status_addr?
I assume you meant data_addr.

>> +		dev_err(&pdev->dev, "memory allocation failed cannot get the I/O addr 0x%x\n",
>> +			(unsigned int)arc_ps2->iomem_res->start);
> I think we have a format specifier for resources.
Thanks, didn't know that!

>> +	iounmap((void __iomem *) arc_ps2->addr);
> No need to cast to __iomem here.
These are remains from the time that addr was still an 'unsigned' (while using inl/outl). Updated.

Patch v3 will follow in due course.


Thanks again,

Mischa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/