linux-kernel - RE: ata4.00: failed to get Identify Device Data, Emask 0x1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43EB3AB3EEFE8D43B525F4D2EAF507E107EA8AA9@SCYBEXDAG03.amd.com>
Date:	Thu, 18 Oct 2012 09:11:05 +0000
From:	"Huang, Shane" <Shane.Huang@....com>
To:	Aaron Lu <aaron.lu@...el.com>,
	Robert Hancock <hancockrwd@...il.com>
CC:	Borislav Petkov <bp@...64.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Huang, Shane" <Shane.Huang@....com>
Subject: RE: ata4.00: failed to get Identify Device Data, Emask 0x1

> Agree. If NCQ does not imply support of this log page, we should
> definitely refine the check condition used here.
> 
> I suppose Shane will take care of this, but if he doesn't, I'll do that
> at a later time.

I tried word 78 bit 5(Hardware Feature Control) which does not work,
it is 0 on my HDD sample with log 30h page 08h and DevSlp supported.

Seems that word 78 bit 5 is only the sufficient condition, not the
essential condition. Do you guys have suggestion?

Quoting SATA spec:
> Word 78: Serial ATA features supported
> Bit 5 If bit 5 is set to one, then Hardware Feature Control is
> supported (see 13.10). If bit 5 is cleared to zero, then Hardware
> Feature Control is not supported and IDENTIFY DEVICE data
> word 79 bit 5 shall be cleared to zero.
> 
> If Hardware Feature Control is supported, then:
> a) IDENTIFY DEVICE data word 78 bit 5 (see 13.2.1.18) shall be
> set to one;
> b) the SET FEATURES Select Hardware Feature Control subcommand
> shall be supported (see 13.3.8);
> c) page 08h of the Identify Device Data log (see 13.7.7) shall
> be supported;


Thanks,
Shane

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/