linux-kernel - Re: [PATCH 2/3] Drivers: hv: Cleanup error handling in vmbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121018094625.GB5685@mwanda>
Date:	Thu, 18 Oct 2012 12:46:25 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, olaf@...fle.de, apw@...onical.com,
	jasowang@...hat.com, Stable <stable@...r.kernel.org>
Subject: Re: [PATCH 2/3] Drivers: hv: Cleanup error handling in vmbus_open()

On Fri, Oct 12, 2012 at 01:22:42PM -0700, K. Y. Srinivasan wrote:
> -errorout:
> -	hv_ringbuffer_cleanup(&newchannel->outbound);
> -	hv_ringbuffer_cleanup(&newchannel->inbound);
> +error1:
> +	spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags);
> +	list_del(&open_info->msglistentry);
> +	spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);
> +
> +error0:

It's better to give the labels meaningful names like error_del and
error_pages instead of GW-BASIC numbers.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/