linux-kernel - Re: CONFIG_MODULE_SIG breaks out-of-tree modules in modpost.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1350557870-5660-1-git-send-email-s.knoblich@axsentis.de>
Date:	Thu, 18 Oct 2012 12:57:50 +0200
From:	Stefan Knoblich <s.knoblich@...entis.de>
To:	linux-kernel@...r.kernel.org
Cc:	weiyj.lk@...il.com, dhowells@...hat.com,
	Stefan Knoblich <s.knoblich@...entis.de>
Subject: Re: CONFIG_MODULE_SIG breaks out-of-tree modules in modpost.

I've had the same problem building dahdi-linux-2.6.1, attached
patch fixed it:

From: Stefan Knoblich <s.knoblich@...entis.de>
Date: Tue, 16 Oct 2012 12:40:29 +0200
Subject: [PATCH] MODSIGN: Fix modpost for external modules with
 CONFIG_MODULE_SIG=y

Modpost with CONFIG_MODULE_SIG=y skips the signing step for external
modules by forcing SIGN_MODULES=0, breaking the build because
cmd_sign_ko_ko_stripped is undefined in that case:

  CC      /tmp/dahdi-linux-2.6.1/drivers/dahdi/../staging/echo/echo.mod.o
  LD [M]  /tmp/dahdi-linux-2.6.1/drivers/dahdi/../staging/echo/echo.ko.unsigned
  STRIP [M] /tmp/dahdi-linux-2.6.1/drivers/dahdi/../staging/echo/echo.ko.stripped
/bin/sh: -c: line 0: syntax error near unexpected token `;'
/bin/sh: -c: line 0: `set -e;  ; echo 'cmd_/tmp/dahdi-linux-2.6.1/drivers/dahdi/
../staging/echo/echo.ko := ' > /tmp/dahdi-linux-2.6.1/drivers/dahdi/
../staging/echo/.echo.ko.cmd'

Renaming the misnamed {quiet_,}cmd_sign_ko_ko_unsigned commands
fixes that error.

Signed-off-by: Stefan Knoblich <s.knoblich@...entis.de>
---
 scripts/Makefile.modpost |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
index 0020891..85c0d10 100644
--- a/scripts/Makefile.modpost
+++ b/scripts/Makefile.modpost
@@ -188,8 +188,8 @@ quiet_cmd_sign_ko_ko_stripped = SIGN [M] $@
 		sh $(SCRIPTS_DIR)/sign-file $(MODSECKEY) $(MODPUBKEY) $< $@
 else
 KEYRING_DEP :=
-quiet_cmd_sign_ko_ko_unsigned = NO SIGN [M] $@
-      cmd_sign_ko_ko_unsigned = \
+quiet_cmd_sign_ko_ko_stripped = NO SIGN [M] $@
+      cmd_sign_ko_ko_stripped = \
 		cp $< $@
 endif
 
-- 
1.7.8.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/