linux-kernel - Re: [patch for-3.7] fs, xattr: fix bug when removing a name not in xattr list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Oct 2012 20:43:03 +0800
From:	Hillf Danton <dhillf@...il.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Hugh Dickins <hughd@...gle.com>, Li Zefan <lizefan@...wei.com>,
	Aristeu Rozanski <aris@...hat.com>, Tejun Heo <tj@...nel.org>,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	James Morris <jmorris@...ei.org>,
	Dmitry Kasatkin <dmitry.kasatkin@...el.com>,
	linux-sec@...per.es, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [patch for-3.7] fs, xattr: fix bug when removing a name not in
 xattr list

Hi David,

On Thu, Oct 18, 2012 at 11:41 AM, David Rientjes <rientjes@...gle.com> wrote:
> Commit 38f38657444d ("xattr: extract simple_xattr code from tmpfs") moved
> some code from tmpfs but introduced a subtle bug along the way.
>
That commit is fine but you did revert commit b9d6cfdeaf67(xattr: mark
variable as uninitialized to make both gcc and smatch happy), too late
to spin?

Hillf
> If the name passed to simple_xattr_remove() does not exist in the list of
> xattrs, then it is possible to call kfree(new_xattr) when new_xattr is
> actually initialized to itself on the stack via uninitialized_var().
>
> This causes a BUG() since the memory was not allocated via the slab
> allocator and was not bypassed through to the page allocator because it
> was too large.
>
> Initialize the local variable to NULL so the kfree() never takes place.
>
> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
>  fs/xattr.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xattr.c b/fs/xattr.c
> --- a/fs/xattr.c
> +++ b/fs/xattr.c
> @@ -846,7 +846,7 @@ static int __simple_xattr_set(struct simple_xattrs *xattrs, const char *name,
>                               const void *value, size_t size, int flags)
>  {
>         struct simple_xattr *xattr;
> -       struct simple_xattr *uninitialized_var(new_xattr);
> +       struct simple_xattr *new_xattr = NULL;
>         int err = 0;
>
>         /* value == NULL means remove */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/