linux-kernel - Re: [PATCH] kvm/ftrace: change the diplaying format of vector in trace_msi_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Oct 2012 16:49:00 +0200
From:	Avi Kivity <avi@...hat.com>
To:	"Sanagi, Koki" <sanagi.koki@...fujitsu.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>,
	"fweisbec@...il.com" <fweisbec@...il.com>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"mtosatti@...hat.com" <mtosatti@...hat.com>
Subject: Re: [PATCH] kvm/ftrace: change the diplaying format of vector in
 trace_msi_set_irq

On 10/12/2012 02:03 AM, Sanagi, Koki wrote:
> This patch changes the way to diplay the vector in trace_msi_set_irq from %x to
> %u.  Currently, it mismatches another output of ftrace such as kvm_msi_set_irq
> and kvm_inj_virq which uses %u.
> 
> Signed-off-by: Koki Sanagi <sanagi.koki@...fujitsu.com>
> ---
>  include/trace/events/kvm.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
> index 7ef9e75..0a83632 100644
> --- a/include/trace/events/kvm.h
> +++ b/include/trace/events/kvm.h
> @@ -109,7 +109,7 @@ TRACE_EVENT(kvm_msi_set_irq,
>  		__entry->data		= data;
>  	),
>  
> -	TP_printk("dst %u vec %x (%s|%s|%s%s)",
> +	TP_printk("dst %u vec %u (%s|%s|%s%s)",
>  		  (u8)(__entry->address >> 12), (u8)__entry->data,
>  		  __print_symbolic((__entry->data >> 8 & 0x7), kvm_deliver_mode),
>  		  (__entry->address & (1<<2)) ? "logical" : "physical",


Changing them all to %02x is probably better.  For example, writes to
APIC_ICR will be shown as hex, with the vector in the low order 8 bits,
so it will be easier to match them if they are all in hex.


-- 
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/