linux-kernel - Re: [PATCH 2/4] thp: introduce hugepage_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1210181314380.26994@chino.kir.corp.google.com>
Date:	Thu, 18 Oct 2012 13:15:13 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Bob Liu <lliubbo@...il.com>
cc:	akpm@...ux-foundation.org, aarcange@...hat.com,
	xiaoguangrong@...ux.vnet.ibm.com, hughd@...gle.com,
	linux-kernel@...r.kernel.org, kirill.shutemov@...ux.intel.com
Subject: Re: [PATCH 2/4] thp: introduce hugepage_get_pmd()

On Thu, 18 Oct 2012, Bob Liu wrote:

> Introduce hugepage_get_pmd() to simple code.
> 

I don't see this as simple just because you're removing more lines, I find 
pagetable walks to be harder to read when split up like this and the "get" 
part implies you're grabbing a reference on the pmd, which you're not.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/