linux-kernel - Re: [PATCH 3/4] thp: introduce hugepage_vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121018133225.53f0e247.akpm@linux-foundation.org>
Date:	Thu, 18 Oct 2012 13:32:25 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Bob Liu <lliubbo@...il.com>, aarcange@...hat.com,
	xiaoguangrong@...ux.vnet.ibm.com, hughd@...gle.com,
	linux-kernel@...r.kernel.org, kirill.shutemov@...ux.intel.com
Subject: Re: [PATCH 3/4] thp: introduce hugepage_vma_check()

On Thu, 18 Oct 2012 13:16:04 -0700 (PDT)
David Rientjes <rientjes@...gle.com> wrote:

> On Thu, 18 Oct 2012, Bob Liu wrote:
> 
> > Multi place do the same check.
> > 
> 
> This only succeeds in removing four lines and makes the code more 
> difficult to follow

I like it.  It takes a bunch of code sequences which may or may not be the
same and removes all doubt, while making the call sites clearer.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/