linux-kernel - Re: [PATCH v2] Documentation DMA-API-HOWTO.txt Add dma mapping error check usage examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1210182331390.17217@swampdragon.chaosbits.net>
Date:	Thu, 18 Oct 2012 23:32:55 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Shuah Khan <shuah.khan@...com>
cc:	mtk.manpages@...il.com, Dan Carpenter <dan.carpenter@...cle.com>,
	konrad.wilk@...cle.com, rob@...dley.net, joerg.roedel@....com,
	Andrew Morton <akpm@...ux-foundation.org>,
	devel@...uxdriverproject.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, shuahkhan@...il.com
Subject: Re: [PATCH v2] Documentation DMA-API-HOWTO.txt Add dma mapping error
 check usage examples

On Thu, 18 Oct 2012, Shuah Khan wrote:

> Enhance the document to discuss the importance of dma mapping error checks
> after dma_map_single() and dma_map_page() calls. Also added usage examples
> that include unmap examples in error paths when dma mapping error is returned.
> Includes correct and incorrect usages to high light some common mistakes in
> error paths especially when dma mapping fails when more than one dma mapping
> call is made.
> 
> Signed-off-by: Shuah Khan <shuah.khan@...com>
[...]

Nit picking :

> +Example 2: (if buffers are allocated a loop, unmap all mapped buffers when
> +	    mapping error is detected in the middle)
> +

"... if buffers are allocated in a loop..."

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/