linux-kernel - [PATCH] qla3xxx: Ensure request/response queue addr writes to the registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5080AB55.9010609@oracle.com>
Date:	Fri, 19 Oct 2012 09:22:29 +0800
From:	Joe Jin <joe.jin@...cle.com>
To:	Ron Mercer <ron.mercer@...gic.com>, Linux-Driver@...gic.com,
	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>,
	Joe Jin <joe.jin@...cle.com>
CC:	netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org,
	Greg Marsden <greg.marsden@...cle.com>
Subject: [PATCH] qla3xxx: Ensure request/response queue addr writes to the
 registers

Before use the request and response queue addr, make sure it has wrote
to the registers.

Signed-off-by: Joe Jin <joe.jin@...cle.com>
Cc: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
Cc: Ron Mercer <ron.mercer@...gic.com>
---
 drivers/net/ethernet/qlogic/qla3xxx.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index df09b1c..f745ade 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -2525,6 +2525,12 @@ static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev)
 	qdev->req_q_size =
 	    (u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));
 
+	/*
+	 * The barrier is required to ensure request and response queue
+	 * addr writes to the registers.
+	 */
+	wmb();
+
 	qdev->req_q_virt_addr =
 	    pci_alloc_consistent(qdev->pdev,
 				 (size_t) qdev->req_q_size,
-- 
1.7.11.7


View attachment "Attached Message Part" of type "text/plain" (0 bytes)