linux-kernel - Re: [PATCH v2 3/3] lp8788-charger: fix wrong ADC conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50814B6A.6010000@metafoo.de>
Date:	Fri, 19 Oct 2012 14:45:30 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	"Kim, Milo" <Milo.Kim@...com>
CC:	"cbou@...l.ru" <cbou@...l.ru>,
	Anton Vorontsov <anton.vorontsov@...aro.org>,
	Jonathan Cameron <jic23@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] lp8788-charger: fix wrong ADC conversion

On 10/19/2012 02:12 AM, Kim, Milo wrote:
>  To get the battery voltage and temperature, IIO ADC functions are used.
>  LP8788 ADC driver provides RAW and SCALE channel information.
>  This patch fixes wrong ADC result.
> 
>  Patch v2.
>  Use simple iio_read_channel_processed() function rather than
>  iio_read_channel_raw() and _scale().
> 
>  Fix the result type of ADC function as a signed integer.
>  Because power_supply_propval.intval and the return value of
>  iio_read_channel_processed() are a signed integer,
>  'unsigned int' are replaced with 'int'.
> 
>  Patch v1.
>  Fix wrong ADC results using iio_read_channel_raw() and _scale().
> 
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>

Looks good to me, fwiw:

Reviewed-by Lars-Peter Clausen <lars@...afoo.de>

But there is one issue, but this is not necessarily related to this patch,
more inline.

> ---
>  drivers/power/lp8788-charger.c |   26 +++++++-------------------
>  1 file changed, 7 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/power/lp8788-charger.c b/drivers/power/lp8788-charger.c
> index 02fc9ab..f18ec8f 100644
> --- a/drivers/power/lp8788-charger.c
> +++ b/drivers/power/lp8788-charger.c
> @@ -235,25 +235,14 @@ static int lp8788_get_battery_present(struct lp8788_charger *pchg,
>  	return 0;
>  }
>  
[...]
>  static int lp8788_get_battery_voltage(struct lp8788_charger *pchg,
> @@ -268,7 +257,7 @@ static int lp8788_get_battery_capacity(struct lp8788_charger *pchg,
>  	struct lp8788 *lp = pchg->lp;
>  	struct lp8788_charger_platform_data *pdata = pchg->pdata;
>  	unsigned int max_vbatt;
> -	unsigned int vbatt;
> +	int vbatt;
>  	enum lp8788_charging_state state;
>  	u8 data;
>  	int ret;
> @@ -304,19 +293,18 @@ static int lp8788_get_battery_temperature(struct lp8788_charger *pchg,
>  				union power_supply_propval *val)
>  {
>  	struct iio_channel *channel = pchg->chan[LP8788_BATT_TEMP];
> -	int scaleint;
> -	int scalepart;
> +	int result;
>  	int ret;
>  
>  	if (!channel)
>  		return -EINVAL;
>  
> -	ret = iio_read_channel_scale(channel, &scaleint, &scalepart);
> -	if (ret != IIO_VAL_INT_PLUS_MICRO)
> +	ret = iio_read_channel_processed(channel, &result);
> +	if (ret < 0)
>  		return -EINVAL;
>  
>  	/* unit: 0.1 'C */
> -	val->intval = (scaleint + scalepart * 1000000) / 100;
> +	val->intval = result * 10;

IIO reports temperatures in milli degree Celsius. So it should be multiplied
by 100 to get tenth degree like the power supply framework expects it. But
this might be a issue in your IIO driver reporting the wrong scale.

- Lars

>  
>  	return 0;
>  }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/