linux-kernel - Re: [PATCH 1/3] lp8788-charger: use consumer device name on setting IIO channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <508173B6.20806@kernel.org>
Date:	Fri, 19 Oct 2012 16:37:26 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	"Kim, Milo" <Milo.Kim@...com>
CC:	"cbou@...l.ru" <cbou@...l.ru>,
	Anton Vorontsov <anton.vorontsov@...aro.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] lp8788-charger: use consumer device name on setting
 IIO channels

On 10/18/2012 07:11 AM, Kim, Milo wrote:
>  To get the ADC value for the battery voltage and temperature,
>  LP8788 ADC driver is used.
>  LP8788 charger driver is the consumer of LP8788 ADC driver.
>  Thus, specific ADC driver name is required on getting the channel
>  using iio_channel_get().
> 
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>
Acked-by: Jonathan Cameron <jic23@...nel.org>

> ---
>  drivers/power/lp8788-charger.c |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/power/lp8788-charger.c b/drivers/power/lp8788-charger.c
> index e852d12..614e6aa 100644
> --- a/drivers/power/lp8788-charger.c
> +++ b/drivers/power/lp8788-charger.c
> @@ -592,7 +592,8 @@ static void lp8788_irq_unregister(struct platform_device *pdev,
>  	}
>  }
>  
> -static void lp8788_setup_adc_channel(struct lp8788_charger *pchg)
> +static void lp8788_setup_adc_channel(const char *consumer_name,
> +				struct lp8788_charger *pchg)
>  {
>  	struct lp8788_charger_platform_data *pdata = pchg->pdata;
>  	struct device *dev = pchg->lp->dev;
> @@ -616,7 +617,7 @@ static void lp8788_setup_adc_channel(struct lp8788_charger *pchg)
>  	case LPADC_VBATT_5P5:
>  	case LPADC_VBATT_6P0:
>  	case LPADC_VBATT_5P0:
> -		chan = iio_channel_get(NULL, chan_name[id]);
> +		chan = iio_channel_get(consumer_name, chan_name[id]);
>  		pchg->chan[LP8788_VBATT] = IS_ERR(chan) ? NULL : chan;
>  		break;
>  	default:
> @@ -631,7 +632,7 @@ static void lp8788_setup_adc_channel(struct lp8788_charger *pchg)
>  	case LPADC_ADC2:
>  	case LPADC_ADC3:
>  	case LPADC_ADC4:
> -		chan = iio_channel_get(NULL, chan_name[id]);
> +		chan = iio_channel_get(consumer_name, chan_name[id]);
>  		pchg->chan[LP8788_BATT_TEMP] = IS_ERR(chan) ? NULL : chan;
>  		break;
>  	default:
> @@ -747,7 +748,7 @@ static __devinit int lp8788_charger_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	lp8788_setup_adc_channel(pchg);
> +	lp8788_setup_adc_channel(pdev->name, pchg);
>  
>  	ret = lp8788_psy_register(pdev, pchg);
>  	if (ret)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/