linux-kernel - Re: [PATCH 1/3] staging/sbe-2t3e3: Use netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121019191038.GA18369@kroah.com>
Date:	Fri, 19 Oct 2012 12:10:38 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	YAMANE Toshiaki <yamanetoshi@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging/sbe-2t3e3: Use netdev_ printks in main.c

On Thu, Sep 27, 2012 at 10:57:51PM +0900, YAMANE Toshiaki wrote:
> fixed below checkpatch warning.
> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
> 
> Signed-off-by: YAMANE Toshiaki <yamanetoshi@...il.com>

Your coding style cleanup patch introduced more coding style errors, not
good.  Please always remember to use checkpatch.pl on your patches you
create.

please fix up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/