[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <508276D3.5000708@gmail.com>
Date: Sat, 20 Oct 2012 12:02:59 +0200
From: Marco Stornelli <marco.stornelli@...il.com>
To: Richard Weinberger <richard@....at>
CC: Jeff Dike <jdike@...toit.com>,
user-mode-linux-devel@...ts.sourceforge.net,
linux-kernel@...r.kernel.org,
Christoph Hellwig <hch@...radead.org>,
Linux FS Devel <linux-fsdevel@...r.kernel.org>
Subject: [PATCH] hostfs: fix a not needed double check
With the commit 3be2be0a32c18b0fd6d623cda63174a332ca0de1 we removed vmtruncate,
but actaully there is no need to call inode_newsize_ok() because the checks are
already done in inode_change_ok() at the begin of the function.
Signed-off-by: Marco Stornelli <marco.stornelli@...il.com>
---
fs/hostfs/hostfs_kern.c | 9 +--------
1 files changed, 1 insertions(+), 8 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 457addc..c9d5254 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_kern.c
@@ -845,15 +845,8 @@ int hostfs_setattr(struct dentry *dentry, struct iattr *attr)
return err;
if ((attr->ia_valid & ATTR_SIZE) &&
- attr->ia_size != i_size_read(inode)) {
- int error;
-
- error = inode_newsize_ok(inode, attr->ia_size);
- if (error)
- return error;
-
+ attr->ia_size != i_size_read(inode))
truncate_setsize(inode, attr->ia_size);
- }
setattr_copy(inode, attr);
mark_inode_dirty(inode);
--
1.7.3.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists