linux-kernel - [tip:perf/urgent] ring-buffer: Check for uninitialized cpu buffer before resizing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-8e49f418c9632790bf456634742d34d97120a784@git.kernel.org>
Date:	Sun, 21 Oct 2012 11:37:24 -0700
From:	tip-bot for Vaibhav Nagarnaik <vnagarnaik@...gle.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, vnagarnaik@...gle.com, hpa@...or.com,
	mingo@...nel.org, rostedt@...dmis.org, tglx@...utronix.de
Subject: [tip:perf/urgent] ring-buffer:
  Check for uninitialized cpu buffer before resizing

Commit-ID:  8e49f418c9632790bf456634742d34d97120a784
Gitweb:     http://git.kernel.org/tip/8e49f418c9632790bf456634742d34d97120a784
Author:     Vaibhav Nagarnaik <vnagarnaik@...gle.com>
AuthorDate: Wed, 10 Oct 2012 16:40:27 -0700
Committer:  Steven Rostedt <rostedt@...dmis.org>
CommitDate: Thu, 11 Oct 2012 12:21:48 -0400

ring-buffer: Check for uninitialized cpu buffer before resizing

With a system where, num_present_cpus < num_possible_cpus, even if all
CPUs are online, non-present CPUs don't have per_cpu buffers allocated.
If per_cpu/<cpu>/buffer_size_kb is modified for such a CPU, it can cause
a panic due to NULL dereference in ring_buffer_resize().

To fix this, resize operation is allowed only if the per-cpu buffer has
been initialized.

Link: http://lkml.kernel.org/r/1349912427-6486-1-git-send-email-vnagarnaik@google.com

Cc: stable@...r.kernel.org # 3.5+
Signed-off-by: Vaibhav Nagarnaik <vnagarnaik@...gle.com>
Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
---
 kernel/trace/ring_buffer.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index b32ed0e..b979426 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -1567,6 +1567,10 @@ int ring_buffer_resize(struct ring_buffer *buffer, unsigned long size,
 
 		put_online_cpus();
 	} else {
+		/* Make sure this CPU has been intitialized */
+		if (!cpumask_test_cpu(cpu_id, buffer->cpumask))
+			goto out;
+
 		cpu_buffer = buffer->buffers[cpu_id];
 
 		if (nr_pages == cpu_buffer->nr_pages)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/