linux-kernel - Re: [PATCH 1/2] staging: android: checkpatch.pl fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1350781512.16706.3.camel@joe-AO722>
Date:	Sat, 20 Oct 2012 18:05:12 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ken O'Brien <kernel@...obrien.org>
Cc:	gregkh@...uxfoundation.org, swetland@...gle.com, arve@...roid.com,
	viro@...iv.linux.org.uk, dhowells@...hat.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: android: checkpatch.pl fixes

On Sat, 2012-10-20 at 23:33 +0100, Ken O'Brien wrote:
> Fixed all instances of strings spanning multiple lines from checkpatch.pl.
[]
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
[]
> @@ -556,7 +556,7 @@ static int binder_update_page_range(struct binder_proc *proc, int allocate,
>  		goto free_range;
>  
>  	if (vma == NULL) {
> -		pr_err("binder: %d: binder_alloc_buf failed to "
> +		pr_err("binder: %d: binder_alloc_buf failed to " \
>  		       "map pages in userspace, no vma\n", proc->pid);

Hi Ken.

Nice try, but the "right" way to do this is to coalesce formats like:

		pr_err("binder: %d: binder_alloc_buf failed to map pages in userspace, no vma\n",
		       proc->pid);

and ignore 80 column line lengths for these coalesced formats.

An even better way is to add

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

before any #include and change the format to:

		pr_err("%d: binder_alloc_buf failed to map pages in userspace, no vma\n",
		       proc->pid);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/