linux-kernel - Re: [PATCH 2/9] Staging: winbond: phy_calibration: Fixed coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121021103838.GC14031@elf.ucw.cz>
Date:	Sun, 21 Oct 2012 12:38:38 +0200
From:	Pavel Machek <pavel@....cz>
To:	Joe Perches <joe@...ches.com>
Cc:	Adil Mujeeb <mujeeb.adil@...il.com>, gregkh@...uxfoundation.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] Staging: winbond: phy_calibration: Fixed coding
 style issue

On Fri 2012-10-12 09:53:19, Joe Perches wrote:
> On Fri, 2012-10-12 at 22:07 +0530, Adil Mujeeb wrote:
> > Removed checkpatch.pl script reported ERRORs
> []
> > diff --git a/linux-3.6-rc7/drivers/staging/winbond/phy_calibration.c b/linux-3.6-rc7/drivers/staging/winbond/phy_calibration.c
> []
> > -#define AG_CONST        0.6072529350
> > +#define AG_CONST        (0.6072529350)
> 
> That one is unnecessary.
> checkpatch is defective here.

Agreed.

> I wonder why there is any floating point
> in the code at all though.

Some kind of signal strength computations. I'm not an wifi expert... :-).

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/