lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 Oct 2012 10:14:05 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Stephen Warren <swarren@...dotorg.org> Cc: Linus Walleij <linus.walleij@...ricsson.com>, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Stephen Warren <swarren@...dia.com>, Anmar Oueja <anmar.oueja@...aro.org>, Lee Jones <lee.jones@...aro.org> Subject: Re: [PATCH] pinctrl/nomadik: use irq_create_mapping() On Fri, Oct 19, 2012 at 6:22 PM, Stephen Warren <swarren@...dotorg.org> wrote: > On 10/19/2012 09:09 AM, Linus Walleij wrote: >> From: Linus Walleij <linus.walleij@...aro.org> > >> @@ -931,7 +931,7 @@ static void __nmk_gpio_irq_handler(unsigned int irq, struct irq_desc *desc, >> while (status) { >> int bit = __ffs(status); >> >> - generic_handle_irq(irq_find_mapping(nmk_chip->domain, bit)); >> + generic_handle_irq(irq_create_mapping(nmk_chip->domain, bit)); > > Surely this one can remain as irq_find_mapping() since isn't > nmk_gpio_to_irq() guaranteed to have been called first for this GPIO/IRQ? It's an IRQ handler so it should be robust to spurious IRQs due to transient hardware states etc I believe. So if there is a transient IRQ before gpio_to_irq() is called -> boom. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists