linux-kernel - Re: [PATCH 1/2] staging: android: checkpatch.pl fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1350910971.28457.3.camel@thor>
Date:	Mon, 22 Oct 2012 09:02:51 -0400
From:	Peter Hurley <peter@...leysoftware.com>
To:	Joe Perches <joe@...ches.com>
Cc:	David Howells <dhowells@...hat.com>,
	Ken O'Brien <kernel@...obrien.org>, gregkh@...uxfoundation.org,
	swetland@...gle.com, arve@...roid.com, viro@...iv.linux.org.uk,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: android: checkpatch.pl fixes

On Mon, 2012-10-22 at 05:15 -0700, Joe Perches wrote:
> waOn Mon, 2012-10-22 at 10:37 +0100, David Howells wrote:
> > Joe Perches <joe@...ches.com> wrote:
> > 
> > > On Sat, 2012-10-20 at 23:33 +0100, Ken O'Brien wrote:
> > > ...
> > > > -		pr_err("binder: %d: binder_alloc_buf failed to "
> > > > +		pr_err("binder: %d: binder_alloc_buf failed to " \
> > > >  		       "map pages in userspace, no vma\n", proc->pid);
> > > ...
> > > Nice try, but the "right" way to do this is to coalesce formats like:
> > > 
> > > 		pr_err("binder: %d: binder_alloc_buf failed to map pages in userspace, no vma\n",
> > > 		       proc->pid);
> > 
> > Surely the right way is to fix _checkpatch_ to see ["]\n\s*["] and merge the
> > lines before checking them?  We shouldn't have to fix up the source in either
> > of these fashions just because checkpatch is broken.
> 
> checkpatch is stupid, but it's not broken here.
> 
> Formats should be coalesced into a single line to make
> grepping the source for dmesg output easier.

But MODULE_PARM_DESC() multi-line strings are ok, right?

  grep - 'MODULE_PARM_DESC.*"$' drivers

shows it's in widespread use.

> More likely checkpatch could be changed to bleat yet
> another warning like
> 
> "line continuation used outside macro definition"


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/