linux-kernel - Re: [PATCH] ASoC: jack: remove unused variable in snd_soc_jack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121022135048.GI4477@opensource.wolfsonmicro.com>
Date:	Mon, 22 Oct 2012 14:50:48 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	lrg@...com, perex@...ex.cz, tiwai@...e.de,
	yongjun_wei@...ndmicro.com.cn, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: jack: remove unused variable in
 snd_soc_jack_report()

On Thu, Oct 18, 2012 at 10:49:19PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> The variable oldstatus is initialized but never used
> otherwise, so remove the unused variable.

Applied, thanks.  However for changes like this you should really
consider in your changelog why the variable is unused - is the bug that
the result is ignored or that it is needlessly generated?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)