| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 Oct 2012 10:13:01 -0700 From: Julius Werner <jwerner@...omium.org> To: Daniel Lezcano <daniel.lezcano@...aro.org> Cc: linux-kernel@...r.kernel.org, len.brown@...el.com, khilman@...com, rjw@...k.pl, deepthi@...ux.vnet.ibm.com, akpm@...ux-foundation.org, Trinabh Gupta <g.trinabh@...il.com>, snanda@...omium.org, Lists Linaro-dev <linaro-dev@...ts.linaro.org> Subject: Re: [PATCH] acpi/cpuidle: reinitialize power_usage values when adding/removing C-states > Could we just say this is always true because state[i+1] consumes less > than state[i] ? > > And then just remove the 'set_power_state' function, and the field > 'driver->power_specified' ? > > That will cleanup the code and fix this problem, no ? I totally agree with your analysis. Even if a driver were to set proper usage values (and the power_specified bit), none of the existing governors would care about those actual numbers (and since the vast majority of drivers uses fake values anyway, this is not likely to change in the future). This seems to be a classic example of unnecessary over-engineering. I am mostly interested in getting that bug fixed right now, but removing unnecessary code is always a good thing. If you think it would have a good chance of getting merged, I would be happy to draft up a larger patch that refactors power_usage away completely. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists