linux-kernel - Re: [PATCH] vfs: fix: don't increase bio_slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5085932D.4000108@kernel.dk>
Date:	Mon, 22 Oct 2012 20:40:45 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Anna Leuschner <anna.m.leuschner@...il.com>
CC:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfs: fix: don't increase bio_slab_max if krealloc() fails

On 2012-10-21 22:33, Anna Leuschner wrote:
> bio.c: fix: don't increase bio_slab_max if krealloc() of bio_slabs fails

You failed the "how to write a commit message" part of the patch :-)
The commit message should talk about WHY a change is necessary, not
HOW it is done. The latter should be obvious from looking at the code
change.

So, in other words, please describe why the change is useful or needed.
Then resend.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/