linux-kernel - Re: [PATCH v2] menuconfig: Replace CIRCLEQ by list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201210222138.25805.yann.morin.1998@free.fr>
Date:	Mon, 22 Oct 2012 21:38:25 +0200
From:	"Yann E. MORIN" <yann.morin.1998@...e.fr>
To:	Michal Marek <mmarek@...e.cz>
Cc:	linux-kbuild@...r.kernel.org,
	Benjamin Poirier <benjamin.poirier@...il.com>,
	Jean Sacren <sakiwit@...il.com>,
	Arnaud Lacombe <lacombar@...il.com>,
	Wang YanQing <udknight@...il.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Davidlohr Bueso <dave@....org>, linux-kernel@...r.kernel.org,
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
	Yaakov Selkowitz <yselkowitz@...rs.sourceforge.net>
Subject: Re: [PATCH v2] menuconfig: Replace CIRCLEQ by list_head-style lists.

Benjamin, Michal, All,

On Sunday 21 October 2012 Benjamin Poirier wrote:
> From: Benjamin Poirier <bpoirier@...e.de>
> 
> sys/queue.h and CIRCLEQ in particular have proven to cause portability
> problems (reported on Debian Sarge, Cygwin and FreeBSD)

Benjamin,

Thank you for working on this! :-)

> Reported-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Tested-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Tested-by: Yaakov Selkowitz <yselkowitz@...rs.sourceforge.net>
> Signed-off-by: Benjamin Poirier <bpoirier@...e.de>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@...e.fr>
> ---
> 
> Changes v1-v2:
> * integrate the patch/suggestion from Yann to fix problems related to the
>   usage of list.h with xconfig/c++
> 	* "new" keyword
> 	* offsetof redefinition
> * silly #endif placement mistake

Michal,

Any more comments on this patch?

If not, then I would suggest to push it for inclusion before 3.7 is released
(I believe it can go in, as it is a bugfix, not a new feature).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/