linux-kernel - Re: [PATCH] staging/comedi: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121022194537.GB30479@kroah.com>
Date:	Mon, 22 Oct 2012 12:45:37 -0700
From:	Greg Kroah-Hartman <greg@...ah.com>
To:	YAMANE Toshiaki <yamanetoshi@...il.com>
Cc:	Ian Abbott <abbotti@....co.uk>,
	Frank Mori Hess <fmhess@...rs.sourceforge.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/comedi: Use dev_ printks in drivers/vmk80xx.c

On Mon, Oct 15, 2012 at 07:58:06PM +0900, YAMANE Toshiaki wrote:
> -	printk(KERN_INFO "comedi#: vmk80xx: board #%d [%s] now attached\n",
> -	       dev->count, dev->board.name);
> +	dev_info(&intf->dev, "vmk80xx: board #%d [%s] now attached\n",
> +		 dev->count, dev->board.name);

The vmk80xx here is redundant, as it shows up from the dev_info()
printk.  Care to fix the two places here you did that and resend?

Note, when you resend please enumerate what version of the patch this
is, otherwise I can get very confused.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/