linux-kernel - Re: [PATCH v2] staging: csr: Replace wakelocks with wakeup interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 22 Oct 2012 14:50:00 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Priit Laes <plaes@...es.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: csr: Replace wakelocks with wakeup interface

On Wed, Oct 03, 2012 at 09:12:30PM +0300, Priit Laes wrote:
> Wakelocks are an Android-specific API that never made into mainline.
> Eventually power management wakeup interface appeared, therefore use
> this interface instead.
> 
> Signed-off-by: Priit Laes <plaes@...es.org>
> ---
>  drivers/staging/csr/drv.c        |  8 ++++----
>  drivers/staging/csr/sdio_mmc.c   | 23 +++++++----------------
>  drivers/staging/csr/sme_sys.c    | 18 +++++++++---------
>  drivers/staging/csr/unifi_priv.h |  8 --------
>  4 files changed, 20 insertions(+), 37 deletions(-)
> 
> diff --git a/drivers/staging/csr/drv.c b/drivers/staging/csr/drv.c
> index 2497580..262705a 100644
> --- a/drivers/staging/csr/drv.c
> +++ b/drivers/staging/csr/drv.c
> @@ -67,6 +67,8 @@ int bh_priority = -1;
>  int log_hip_signals = 0;
>  #endif
>  
> +extern struct wakeup_source unifi_sdio_wakeup_source;

You obviously didn't run scripts/checkpatch.pl against this patch, did
you?

Never put an extern in a .c file, put this in a .h file so that all .c
files can access it properly.

Care to fix this up and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/