linux-kernel - Re: [PATCH] ledtrig-cpu: use spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK5ve-L=sRNGYxsEjuJZrPYszLAgBXEfPfkLnLdHmxfnyCRnDA@mail.gmail.com>
Date:	Mon, 22 Oct 2012 16:15:58 -0700
From:	Bryan Wu <cooloney@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Miles Lane <miles.lane@...il.com>,
	akpm <akpm@...ux-foundation.org>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ledtrig-cpu: use spin_lock to replace mutex lock

On Mon, Oct 22, 2012 at 3:38 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> On Monday 22 of October 2012 11:59:19 Bryan Wu wrote:
>> Hiya,
>>
>> Can I get some Acked or Tested-by from Rafael or Miles before I put it
>> in my linux-leds tree?
>
> Well, I just explained why the current code didn't work. :-)
>
> Anyway, please feel free to add
>
> Acked-by: Rafael J. Wysocki <rjw@...k.pl>
>

I was just reminded by Nathan Lynch <ntl@...ox.com> most of
led-trigger API like register/unregister/event are potentially sleep.
They should not be used in atomic context. Any suggestion to fix it?

Thanks,
-Bryan

>
>> On Thu, Oct 18, 2012 at 12:34 PM, Bryan Wu <cooloney@...il.com> wrote:
>> > On Thu, Oct 18, 2012 at 11:35 AM, Linus Walleij
>> > <linus.walleij@...aro.org> wrote:
>> >> On Thu, Oct 18, 2012 at 8:18 PM, Bryan Wu <cooloney@...il.com> wrote:
>> >>
>> >>> Mutex lock is not safe in atomic context like the bug reported by
>> >>> Miles Lane:
>> >> (...)
>> >>> This patch replace mutex lock with spin lock which is safe for this case.
>> >>>
>> >>> Reported-by: Miles Lane <miles.lane@...il.com>
>> >>> Reported-by: Rafael J. Wysocki <rjw@...k.pl>
>> >>> Cc: Linus Walleij <linus.walleij@...aro.org>
>> >>> Signed-off-by: Bryan Wu <cooloney@...il.com>
>> >>
>> >> Looks correct to me:
>> >> Acked-by: Linus Walleij <linus.walleij@...aro.org>
>> >>
>> >
>> > Thanks, Linus.
>> >
>> > Miles, could you please help to try this patch on your testing system?
>> > I really appreciate it.
>> >
>> > -Bryan
>>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/