linux-kernel - Re: [PATCH 070/193] drivers/mmc/core: remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <876260hl0p.fsf@octavius.laptop.org>
Date:	Tue, 23 Oct 2012 18:38:14 -0400
From:	Chris Ball <cjb@...top.org>
To:	Kees Cook <keescook@...omium.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 070/193] drivers/mmc/core: remove CONFIG_EXPERIMENTAL

Hi,

On Tue, Oct 23 2012, Kees Cook wrote:
> This config item has not carried much meaning for a while now and is
> almost always enabled by default. As agreed during the Linux kernel
> summit, remove it.
>
> CC: Chris Ball <cjb@...top.org>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  drivers/mmc/core/Kconfig |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/Kconfig b/drivers/mmc/core/Kconfig
> index ef10387..269d072 100644
> --- a/drivers/mmc/core/Kconfig
> +++ b/drivers/mmc/core/Kconfig
> @@ -18,8 +18,7 @@ config MMC_UNSAFE_RESUME
>  	  module parameter "removable=0" or "removable=1".
>  
>  config MMC_CLKGATE
> -	bool "MMC host clock gating (EXPERIMENTAL)"
> -	depends on EXPERIMENTAL
> +	bool "MMC host clock gating"
>  	help
>  	  This will attempt to aggressively gate the clock to the MMC card.
>  	  This is done to save power due to gating off the logic and bus

Maybe this isn't important, but:

I think the commit message should be changed -- this part of the series
doesn't remove EXPERIMENTAL, it removes the dependency on it from its
current users.  The way the commit message is worded makes it sound like
the patch is going to remove MMC_CLKGATE, which of course it doesn't.

Ditto the subject line, could be ": remove use of CONFIG_EXPERIMENTAL".

Regardless, for this and the subsequent [071] patch:

Acked-by: Chris Ball <cjb@...top.org>

(Let me know if you'd like me to take these, I don't mind who merges them.)

Thanks,

- Chris.
-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/