linux-kernel - Re: [RFC PATCH v2 6/6] USB: forbid memory allocation with I/O during bus reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVOy+dmjdhBr9Vtww12PZg_fo2y78TcNzuP_Yq9_p=74Hw@mail.gmail.com>
Date:	Tue, 23 Oct 2012 16:44:39 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	linux-kernel@...r.kernel.org, Oliver Neukum <oneukum@...e.de>,
	Minchan Kim <minchan@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Jens Axboe <axboe@...nel.dk>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [RFC PATCH v2 6/6] USB: forbid memory allocation with I/O during
 bus reset

On Mon, Oct 22, 2012 at 10:37 PM, Alan Stern <stern@...land.harvard.edu> wrote:
> On Mon, 22 Oct 2012, Ming Lei wrote:

>>
>> +     /*
>> +      * Don't allocate memory with GFP_KERNEL in current
>> +      * context to avoid possible deadlock if usb mass
>> +      * storage interface or usbnet interface(iSCSI case)
>> +      * is included in current configuration. The easiest
>> +      * approach is to do it for all devices.
>> +      */
>> +     memalloc_noio_save(noio_flag);
>
> Why not check dev->power.memalloc_noio_resume here too?

Yes, we can use the flag here too even though it is introduced
for rutime_resume case.

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/