linux-kernel - Re: [PATCH 05/34] perf, x86: Report PEBS event in a raw format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1350995474.13456.12.camel@twins>
Date:	Tue, 23 Oct 2012 14:31:14 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org, acme@...hat.com,
	eranian@...gle.com, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 05/34] perf, x86: Report PEBS event in a raw format

On Thu, 2012-10-18 at 16:19 -0700, Andi Kleen wrote:
> +       if (event->attr.sample_type & PERF_SAMPLE_RAW) {
> +               raw.size = x86_pmu.pebs_record_size;
> +               raw.data = __pebs;
> +               data.raw = &raw;
> +       } 

The Changelog babbles about registers, yet you export the entire record.

There's the PERF_SAMPLE_REGS thing which has been pointed out to you,
but you fail to include this in your arguments.

Also, there's an alignment issue there, the raw.data is 32bit offset,
the record is u64 aligned, leaving the output stream offset, wrecking
things.

And as with any ABI extension, it should come with useful userspace to
make use of it.

I'll hold off on this one for now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/