lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.44L0.1210231011450.1635-100000@iolanthe.rowland.org>
Date:	Tue, 23 Oct 2012 10:13:02 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Justin P. Mattock" <justinmattock@...il.com>
cc:	gregkh@...uxfoundation.org, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2]staging: "ehci-w90x900" Fix typos.

On Mon, 22 Oct 2012, Justin P. Mattock wrote:

> From: "Justin P. Mattock" <justinmattock@...il.com>
> 
> Signed-off-by: Justin P. Mattock <justinmattock@...il.com>
> 
> ---
> 
> The below patch fixes a typo in staging: "ehci-w90x900"

What does ehci-w90x900 have to do with staging?

>  drivers/usb/host/ehci-w90x900.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-w90x900.c b/drivers/usb/host/ehci-w90x900.c
> index ec59808..a9c28a0 100644
> --- a/drivers/usb/host/ehci-w90x900.c
> +++ b/drivers/usb/host/ehci-w90x900.c
> @@ -13,7 +13,7 @@
>  
>  #include <linux/platform_device.h>
>  
> -/*ebable phy0 and phy1 for w90p910*/
> +/*enable phy0 and phy1 for w90p910*/

Why bother to correct the spelling without also correcting the missing 
whitespace?

>  #define	ENPHY		(0x01<<8)
>  #define PHY0_CTR	(0xA4)
>  #define PHY1_CTR	(0xA8)

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ