linux-kernel - Re: [PATCH 02/26] pstore: add flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKEuMyDhZB4QDLq9yZLQFjXMq2hXhTEToMyQ_rXwc4TZw@mail.gmail.com>
Date:	Tue, 23 Oct 2012 09:54:42 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Irina Tirdea <irina.tirdea@...el.com>
Cc:	Anton Vorontsov <cbouatmailru@...il.com>,
	Colin Cross <ccross@...roid.com>,
	Tony Luck <tony.luck@...el.com>, Chris Ball <cjb@...top.org>,
	linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	Octavian Purdila <octavian.purdila@...el.com>
Subject: Re: [PATCH 02/26] pstore: add flags

On Tue, Oct 23, 2012 at 6:48 AM, Irina Tirdea <irina.tirdea@...el.com> wrote:
> From: Adrian Hunter <adrian.hunter@...el.com>
>
> Let the back end tweak pstore behaviour.  Flags added are:
>
>         PSTORE_NO_HEADINGS
>
>                 Omit pstore heading lines from dumped data

I wonder if the default should be to not show headers, and to add this
flag to the backends that want the pstore-added header. I think the
more common case going forward will to be without headers since
backends should arguably storing metadata themselves.

Thoughts?

>         PSTORE_MAX_KMSG_BYTES
>
>                 Default kmsg_bytes to ULONG_MAX
>
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> Signed-off-by: Irina Tirdea <irina.tirdea@...el.com>

Either way, this patch looks logically fine to me.

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/