linux-kernel - [PATCH 0/3] f2fs: move proc files to debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Oct 2012 11:20:55 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Jaegeuk Kim <jaegeuk.kim@...sung.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	viro@...iv.linux.org.uk, arnd@...db.de, tytso@....edu,
	chur.lee@...sung.com, cm224.lee@...sung.com,
	jooyoung.hwang@...sung.com
Subject: [PATCH 0/3] f2fs: move proc files to debugfs

Here are 3 patches, moving the proc file usage on f2fs to debugfs.

The first one fixes a bug in the gc.h file preventing it from being able
to be included by any other files.

The second patch moves all current proc file accesses to a single file,
removing all #ifdefs from the .c files.  This should have been done in
the first place.

The last file converts the files to use debugfs instead of proc.

Note, these patches have been compile tested only, I haven't tested them
out, as I haven't had the chance to yet.  I'll go do that this afternoon
after I catch up on some other pending kernel work.

One question, it seems that the proc files show all information for all
super blocks in the system, no matter which subdirectory you are reading
from in the proc f2fs tree.  Is that really what you want?  Shouldn't we
only be showing the stats of the superblock we are saying we will
report?  I'll test that later today, and if it really is wrong, will fix
the debugfs code up to handle this properly.

Do these patches look reasonable?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/