linux-kernel - Re: [PATCH] staging: csr: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 23 Oct 2012 12:07:41 +0900
From:	SeongJae Park <sj38.park@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: csr: fix coding style

Thank you for fast reply, Greg.

I was very impressed by your session at Linux Forum,
sent linux kernel patch, made a document about your session(write and
submit your first Linux kernel patch) in Korean, and my patch merged,
have discussion with Linux kernel guys...

These whole thing about my first kernel patch were fantastic and great
experience.

I think I got realized meaning & fun of F/OSS a little bit ;)
So, I would never stop contributing to Linux in any ways.

Thank you very much, Greg, and whole kernel people.

Thanks and Best Regards.
SeongJae Park.

On Tue, Oct 23, 2012 at 11:53 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Tue, Oct 23, 2012 at 11:41:06AM +0900, SeongJae Park wrote:
>> Hello,
>>
>>
>> I think it was my mistake.
>>
>> CsrThread is enclosed by macro #ifdef __KERNEL__
>> and it used by csr_framework_ext.h as CsrThreadHandle type(typedef
>> used at csr_framework_ext_types.h).
>>
>> I think that's why I didn't see build failure.
>
> When building the driver __KERNEL__ is defined :)
>
>> So, I think I should not remove CsrThread.
>> If there is anything I missed or wrong, Please let me know.
>
> No, you are right, this can't be removed just yet, so all is good.
>
> If you want to send more patches cleaning stuff up like this one, that
> would be great.
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/