lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Oct 2012 11:49:44 +0200 From: Ingo Molnar <mingo@...nel.org> To: Prarit Bhargava <prarit@...hat.com> Cc: linux-kernel@...r.kernel.org, Avi Kivity <avi@...hat.com>, Gleb Natapov <gleb@...hat.com>, Alex Williamson <alex.williamson@...hat.com>, Marcelo Tostatti <mtosatti@...hat.com>, Ingo Molnar <mingo@...hat.com>, kvm@...r.kernel.org, x86@...nel.org Subject: Re: [PATCH] x86, add hypervisor name to dump_stack() * Prarit Bhargava <prarit@...hat.com> wrote: > Debugging crash, panics, stack trace WARN_ONs, etc., from both virtual and > bare-metal boots can get difficult very quickly. While there are ways to > decipher the output and determine if the output is from a virtual guest, > the in-kernel hypervisors now have a single registration point and set > x86_hyper. We can use this to output a single extra line on virtual > machines that indicates the hypervisor type. > > Signed-off-by: Prarit Bhargava <prarit@...hat.com> > Cc: Avi Kivity <avi@...hat.com> > Cc: Gleb Natapov <gleb@...hat.com> > Cc: Alex Williamson <alex.williamson@...hat.com> > Cc: Marcelo Tostatti <mtosatti@...hat.com> > Cc: Ingo Molnar <mingo@...hat.com> > Cc: kvm@...r.kernel.org > Cc: x86@...nel.org > --- > arch/x86/kernel/dumpstack.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c > index ae42418b..75a635e 100644 > --- a/arch/x86/kernel/dumpstack.c > +++ b/arch/x86/kernel/dumpstack.c > @@ -17,6 +17,7 @@ > #include <linux/sysfs.h> > > #include <asm/stacktrace.h> > +#include <asm/hypervisor.h> > > > int panic_on_unrecovered_nmi; > @@ -193,6 +194,8 @@ void dump_stack(void) > init_utsname()->release, > (int)strcspn(init_utsname()->version, " "), > init_utsname()->version); > + if (x86_hyper && x86_hyper->name) > + printk("Hypervisor: %s\n", x86_hyper->name); > show_trace(NULL, NULL, &stack, bp); Looks useful, but please don't waste a full new line on it but embedd it in the already existing status line that prints details like release and version. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists